search

hharte / mm_manager

Manager for the Nortel Millennium series of payphones.
Other
54 stars 10 forks source link

Separate modem reset command from intialization #12

Closed kscz closed 2 years ago

kscz commented 2 years ago

This modification adds in a separate step in modem initialization which is simply "reset" before sending the init string.

This modification was made to accomodate modems which cannot reset in the same step as accepting other configuration. This includes the USRobotics 5637 modem - which is generally useful for Linux users where the Conexant drivers haven't been maintained since kernel version 2.4

kscz commented 2 years ago

Looks like the failure is due to the workflow needing permissions to push to the original repo, not because of code failures

hharte commented 2 years ago

@kscz Did you mean to remove the ‘p’ option from optargs?

Otherwise, looks good, thanks!

The workflow failure looks like a bug in my Windows workflow.

kscz commented 2 years ago

Ha, no, I did not mean to remove the 'p' option, I just didn't notice I'd deleted it while considering if I should add in a "reset string" option. Fixing it now!

kscz commented 2 years ago

Okay - fixed, and I have another PR after this which is basically a "fix a bunch of small type mismatches and other things to make a -Wall -Wextra -Werror pass happy"