Closed paugier closed 11 months ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
5b9110b
) 97.83% compared to head (f961833
) 97.83%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@paugier thanks for this; currently flake8
6.1.0 claims it needs pycodestyle
2.11 so we're in a bind here. They combined white space checks into one and autopep8
has them separated.
A potential issue I see here is that you made a change in fix_e225
and fix_e231
is just below it. These are the two things that got merged on the pycodestyle
side. So I would:
fix_e225
also fixes E231, in which case we should probably clean this up a bit more.(Trying to avoid a situation down the road where someone wonders e.g. why fix_e231
never gets called, etc.)
thanks for contribution. This has been fixed in pull-request #696, so we will close this one 🙏 We will release a new version within a few days.
This could fix #689 (see also #1191).
Note that I have no idea of the consequence of this simple change... However, it would be interesting to check if the tests could succeed with pycodestyle 2.11.0.