hhchinh2002 / pe

0 stars 0 forks source link

A person name should be case-insensitive #1

Open hhchinh2002 opened 1 year ago

hhchinh2002 commented 1 year ago

image.png

Even it is stated inside the UG that upper and lower case names are considered as different person, in real life, it is more likely that name should be case-insensitive (john tan and John Tan should be considered as 1 person).

nus-se-bot commented 1 year ago

Team's Response

This issue is judged to be of a "low" severity. Additionally, we have opted to reject it:

  1. NEA officials, as government officials, are expected to type in names in proper format, as this app intended for official use. That is, an official working for the government will be expected to input "John Tan" instead of "john tan".
  2. If a user makes a mistake, they will be able to either edit the name, or perform an undo operation.
  3. If in any case in official documents, a person is named "john tan" without capital letters, he should be differentiated, since all "John Tan" 's are expected to be registered as "John Tan" instead of "john tan" in the app.

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Thanks for your response. I disagree with the decision to reject this bug report, here are my points:

  1. I'm not familiar with NEA organisation, I tried to look it up for where they stated that it is expected to type name in case-sensitive, can you provide me a link to this?
  2. Case-insensitive name matching is a common practice in many industries, including healthcare. For reference, a study published in the Journal of the American Medical Informatics Association (JAMIA) titled "A systematic review of record linkage validity studies" concluded that "the most commonly used method for comparing names in record linkage was the Jaro-Winkler distance, a string comparison algorithm that is insensitive to case and considers transpositions" (JAMIA, 2014). This is because it is recognized that names can be spelled differently, capitalized differently, or written in different formats, and I think it is important to be able to identify the correct person in an application regardless of these variations https://academic.oup.com/jamia/article/21/6/1097/2908998 (Section 4.4.3, page 1106)
  3. The similar situation was mentioned in CS2103T site:

image.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree with this severity downgrade judging that how crucial it is especially in healthcare for an application to be able to record name case-insensitively and remove duplicates, this could lead to misidentification and multiple duplicate and common inconvenience in the long-run when the application records a huge number of patients (as it usually does). Hence, it should fit in with severity.Medium as it's defined to be causing occasional inconvenience to some users, but they can still continue to use the product.