search

hhff / spree-ember

:moneybag: An Ember Ecosystem for Spree Commerce.
http://spree-ember.com
MIT License
77 stars 18 forks source link

Support Ember & Ember Data 1.13.x Tracks #78

Open rb2020 opened 9 years ago

rb2020 commented 9 years ago

Glimmer seems to minimally restrict accessing the product page. This error occurs..

Error while processing route: spree.products.index Cannot read property 'length' of undefined TypeError: Cannot read property 'length' of undefined

Repo: https://github.com/e-karma/ember-spree-bare-app.git

givanse commented 9 years ago

That is not a Glimmer issue, please edit the title, you can see from the stack that the problem is ember-data related. Spree-ember works with the following combination:

"ember": "1.13.0"
"ember-data": "1.0.0-beta.18"

beta 19 introduced the change that causes the error

hhff commented 9 years ago

Thanks @givanse - there's a ton of work that's got to go into this issue - I've done some preliminary stuff but It's not ready for a PR yet.

givanse commented 9 years ago

@hhff It would be good to have a branch or PR with those changes, even if it breaks things. I could look at that and see if I can help ;)