hhhzzzsss / SongPlayer

A Fabric mod for Minecraft that plays noteblocks
MIT License
55 stars 15 forks source link

Can you add this txt format? #11

Open SolsticeSpectrum opened 1 year ago

SolsticeSpectrum commented 1 year ago

Inertia and BleachHack and probably others have recording functionality, it records in this format

0:12:3
6:14:3
10:12:3
12:12:3
18:14:3
22:12:3
24:12:3
30:14:3

tick:tone:instrument

I recorded some beautiful songs from skilled noteblock musicians such as https://www.youtube.com/@acatterz

You can get them here: https://github.com/DarkReaper231/darkhack-resources/raw/main/notebot/songs.zip

Here is the songlist: https://github.com/DarkReaper231/darkhack-resources/blob/main/songlist.txt

These songs usually sound better than what you get from midi and nbs so it would be really nice to include this format

Sk8kman commented 8 months ago

I know this is a tad late (almost a year lol) but I added this functionality in my fork of SongPlayer which you can find on my github if ur still wanting it

SolsticeSpectrum commented 8 months ago

I know this is a tad late (almost a year lol) but I added this functionality in my fork of SongPlayer which you can find on my github if ur still wanting it

Yes I am actually, thanks a lot for the effort! I just checked the txt converter and the fact it even ignores comments is hilarious 🤣🤣, so people can add music info as comments, nice touch.

PS: Making a PR wouldn't hurt

Sk8kman commented 8 months ago

Haha thank you! I made the .txt support a month or so ago but didn't release it until earlier today. I'll edit the changelogs to include that commenting feature, which I honestly forgot I added lol. Thanks for trying my fork out!