Conventions & Optimizations - Githubissues

hhhzzzsss / SongPlayer

A Fabric mod for Minecraft that plays noteblocks

MIT License

60 stars 16 forks source link

Conventions & Optimizations #32

Closed Thojs closed 9 months ago

Thojs commented 9 months ago

In this PR I have made some improvements:

Remove full path names in MidiConverter.
Removed unused imports.
Improved README.md
Commands:
- Moved every existing command to a seperate class.
- Removed large amount of code nesting.
- Improved class naming conventions.
Prevent users from setting command prefix to / (Problem with brigadier command tree)

I have tested the code and everything works perfectly.