search

hhhzzzsss / SongPlayer

A Fabric mod for Minecraft that plays noteblocks
MIT License
60 stars 16 forks source link

Survival Mode not working #61

Open NoteBlockMR opened 1 month ago

NoteBlockMR commented 1 month ago

https://github.com/user-attachments/assets/26d43d5a-3c8a-4d80-aa08-bb4bdd67ac88

If you look at the video, the guitar part doesn't work

Sk8kman commented 1 month ago

Hey! This seems like my version of SongPlayer, not hhhzzzsss's. I'm pretty sure this is because the server is telling the client those note blocks are harps when they aren't. Some servers do that and I have no idea why. I'll work on a build of SongPlayer that uses the blocks below it to determine the instrument rather than looking at block data when I have time.

Edit: I looked at hhhzzzsss's version of SongPlayer and it has the same issue. Someone did make a fix for it on my version but I have yet to implement it.

NoteBlockMR commented 1 month ago

Hey! This seems like my version of SongPlayer, not hhhzzzsss's. I'm pretty sure this is because the server is telling the client those note blocks are harps when they aren't. Some servers do that and I have no idea why. I'll work on a build of SongPlayer that uses the blocks below it to determine the instrument rather than looking at block data when I have time.

Edit: I looked at hhhzzzsss's version of SongPlayer and it has the same issue. Someone did make a fix for it on my version but I have yet to implement it.

I think I know why The block is automatically converted by a plug-in called itemsadder

Radplayz commented 1 week ago

Had a similar issue, see issue #62