search

hhhzzzsss / SongPlayer

A Fabric mod for Minecraft that plays noteblocks
MIT License
60 stars 16 forks source link

Mod breaks in 1.19.2 as opposed to 1.19 #9

Closed TahoeBennie closed 1 year ago

TahoeBennie commented 2 years ago

The mod crashes the moment it tries to run a survival or creative command in version 1.19.2, probably also 1.19.1. I'm guessing this is because of the way the new chat has been implemented, and that is enough to break the automatic commands from this mod.

rfl890 commented 2 years ago

working on a fix for this

Caketaco commented 1 year ago

@mdo992 yo can you build the 1.19.2 fork and shove it into your fork's releases

mdo992 commented 1 year ago

@mdo992 yo can you build the 1.19.2 fork and shove it into your fork's releases

alr i’ll also port to 1.19.3 if there needs changes

Caketaco commented 1 year ago

Lmk where it’s posted

mdo992 commented 1 year ago

Lmk where it’s posted

sorry forgot abt this issue for a bit, heres the jar: https://github.com/mdo992/SongPlayer/releases/tag/v2.0.1

Spicy-Axolotl commented 1 year ago

@mdo992 Sorry to bother you but, is it possible for you to compile a version for 1.19.2? I tried compiling it myself and didn't have any luck. Thanks!

mdo992 commented 1 year ago

@mdo992 Sorry to bother you but, is it possible for you to compile a version for 1.19.2? I tried compiling it myself and didn't have any luck. Thanks!

https://github.com/mdo992/SongPlayer/releases

Spicy-Axolotl commented 1 year ago

Thank you so much!

hhhzzzsss commented 1 year ago

I merged your mdo's 1.19.3 pr, thanks for the help!