search

hholzgra / maposmatic

Mirror of maposmatic repository at savannah.nongnu.org
GNU Affero General Public License v3.0
72 stars 13 forks source link

Failure to render preview thumbnail should not lead to full failure #119

Closed hholzgra closed 11 months ago

hholzgra commented 1 year ago

When we have reached the steps where the preview thumbnail is created, and PNG output is converted into alternative bitmap formats, actual rendering has already succeeded. So a problem in this stage should not lead to complete failure.

This is especially an issue with multipage output where the preview thumbnail is currently created by extracting a few selected pages out of the generated PDF using GhostScript, depending on map style this can take longer than actual map rendering (yes, I'm especially looking at you, Pencil Style, here).

hholzgra commented 11 months ago

Not a general problem, the thumbnail generation is protected by a catch-all "try ... except: pass" block; but the "render time exceeded" timeout may still kick in.

But as now downloadable files are presented even if the render job did not fully succeed such timeouts in the thumbnail step should not really be an issue anymore either.

Closing this for now unless further problems are reported