hholzgra / maposmatic

Mirror of maposmatic repository at savannah.nongnu.org
GNU Affero General Public License v3.0
70 stars 13 forks source link

umap properties like iconUrl are not adopted #123

Open ABJ-Samuel opened 8 months ago

ABJ-Samuel commented 8 months ago

I am trying to render a map with a marker from umap but the iconUrl get not adopted

hartmut-mariadb commented 8 months ago

Can you share the umap file, or give me the number or URL of the map render request you tried?

ABJ-Samuel commented 8 months ago

Thank you for the Quick response

render request: https://print.get-map.org/maps/302842

I don't can upload umap files on github but here a the umap file saved as berlin.txt

hartmut-mariadb commented 8 months ago

Looks as if Umap extended (or just changed) their icon set.

They are using local file paths instead of a "proper" file:// URL for the Icons you can pick from their UI, in your case:

"iconUrl": "/uploads/pictogram/alcohol-24_PpEAcC1.png"

I have a regular expression in place that will find such "/uploads/pictogram/" references and rewrite them to use local SVG icons on my server instead, but I only have a SVG icon for "alcohol-shop", not for "alcohol".

Need to see how to get things in sync again ...

ABJ-Samuel commented 8 months ago

Perfect thank you, With umap you can also enter a number instead of images, for example.

Unfortunately, this will not be adopted either.

My original problem is that I would like to number the markers

hartmut-mariadb commented 8 months ago

With umap you can also enter a number instead of images

that seems to be a new feature available on the original .fr instance, but not the .de one yet, so I wasn't even aware of that. Need to figure out how this is actually stored in the exported save file ... I'll probably create a separate issue for that ...

hartmut-mariadb commented 8 months ago

Both the .fr and .de icon schemes should now work, and short text labels, too

hartmut-mariadb commented 8 months ago

mostly fixed now, "icon from text" only works with Unicode Basic Multilingual Plane characters though, not with anything from the extended planes. So ☃ works, but 😃 does not and gets rendered as ������ instead ...