search

hholzgra / ocitysmap

Fork of ocitysmap repository at savannah.nongnu.org
Other
35 stars 12 forks source link

Refactor UMAP json parsing using JQ #65

Closed hholzgra closed 1 year ago

hholzgra commented 1 year ago

In the end I decided to use JSONpath-ng instead, hoping for simpler / more understandable code. In the end it turned out to be not that much better that way, just a little bit.

The Umap.py file is a bit more compact now, but that is mostly due to moving duplicate code into an extra function, which would also have been possible using the old approach.

In the end I left the JSONpath-ng approach in, it works and is minimally more readble (I hope), but looking back it was not really that much worth the effort ...

hholzgra commented 1 year ago

Not following this path any further ...