hhroc / yellr-server

Server for yellr project
GNU Affero General Public License v3.0
6 stars 5 forks source link

Double-check localization code usage. ISO 639-1 #234

Open gregjurman opened 9 years ago

gregjurman commented 9 years ago

Double check if server is using the four letter language code(en-US, es-ES) or just the two(en, es). Much like The Queen's English (en-GB) verses 'murican (en-US), there are differences between the Spanish (es-ES, es-MX) languages as well.

Most systems will spit out a four letter code for i18n/L10n compliance as it is a user preference. The server should respect the four letter code, and only degrade to two if there is no direct match.

thequbit commented 8 years ago

I think we'll just split on "-" and take the first part. That is how it is currently implemented. Will keep this open for discussion though.