hhromic / e131-node

Node.js client/server library for the E1.31 (sACN) protocol
Apache License 2.0
28 stars 12 forks source link

Server only works with a single network interface #6

Open respectTheCode opened 6 years ago

respectTheCode commented 6 years ago

When running on a machine with multiple network interfaces only the primary interface works. Im my use case sACN is on an isolated network. This can be fixed by specifying the IP of the desired interface when calling _socket.addMembership.

As a work around I am calling

dmx.on("listening", function() {
    const multicastGroup = "239.255." + (universe >> 8) + "." + (universe & 0xff);
    dmx._socket.addMembership(multicastGroup, dmxInterfaceIP);
hhromic commented 6 years ago

Hi, thanks for reporting! Indeed I didn't consider multiple interfaces in the original implementation. Thanks for providing a suggestion, I will try to incorporate it as soon as possible.

TimoteusRuotsalainen commented 1 year ago

Any chance in getting this pull request and https://github.com/hhromic/e131-node/issues/21 combined and merged into the project? I can help with the pull request but need to know will it be merged?

hhromic commented 1 year ago

Wow, I completely forgot about this project for several years. I deeply apologise for not coming back to it. Let me check the pending PRs and start merging.

TimoteusRuotsalainen commented 6 months ago

@respectTheCode I created a pull request that includes this functionality. Are you still using this library? https://github.com/hhromic/e131-node/pull/22