fixed issue with packets being discarded when using multiple universe…

hhromic / e131-node

Node.js client/server library for the E1.31 (sACN) protocol

Apache License 2.0

28 stars 12 forks source link

fixed issue with packets being discarded when using multiple universe… #8

Closed atoudam closed 5 years ago

atoudam commented 5 years ago

…s (in server mode) due to only a single global lastSequenceNumber being stored, now a separate lastSequenceNumber is stored for each universe

atoudam commented 5 years ago

no worries, happy to help, love your work on this library it has been very useful hopefully i have made those changes correctly, I'm a bit new to the pull request system

hhromic commented 5 years ago

Thanks for the update. Don't worry, we were all learners at some point! Tip: don't close the PR yourself, it will be automatically closed once it's merged. I found some extra minor coding style issues, review them and I think will be ready to merge. Thanks again!

atoudam commented 5 years ago

thanks, i should have got them all, however i have difficultly confirming i removed the indent but left the line

hhromic commented 5 years ago

Hi, sorry for the long delay on this. I got very busy recently and completely forgot about this PR. I will merge it now. Thanks for the contribution and the fix!