search

hhu-stups / prob-issues

ProB issues (for probcli, ProB Tcl/Tk, ProB2, ProB2UI)
6 stars 0 forks source link

Calls to non-exported module predicates #194

Open pmoura opened 2 years ago

pmoura commented 2 years ago

Using Logtalk 3.57.0-b07 (git version). Prolog module systems are very permissive and these issues often accumulate unnoticed 😔 The linter warning prints "Unknown message sent to object" simply because the modules are being compiled as objects. But these are all calls to non-exported predicates from other modules.

*     Unknown message sent to object: state_space::trace/1
*       while compiling object tcltk_interface
*       in file /Users/pmoura/ProB_src/src/tcltk_interface.pl between lines 872-877
*     
*     Unknown message sent to object: specfile::b_trans/5
*       while compiling object tcltk_interface
*       in file /Users/pmoura/ProB_src/src/tcltk_interface.pl between lines 1106-1113
*     Unknown message sent to object: error_manager::print_error_span/2
*       while compiling object kernel_objects
*       in file /Users/pmoura/ProB_src/src/kernel_objects.pl between lines 947-955
*     Unknown message sent to object: kernel_objects::warn_if_duplicates_in_list/3
*       while compiling object custom_explicit_sets
*       in file /Users/pmoura/ProB_src/src/custom_explicit_sets.pl between lines 4383-4384
*     Unknown message sent to object: custom_explicit_sets::membership_global_set/4
*       while compiling object b_compiler
*       in file /Users/pmoura/ProB_src/src/b_compiler.pl between lines 908-910
*     Unknown message sent to object: kernel_objects::lazy_try_check_element_of/3
*       while compiling object b_interpreter
*       in file /Users/pmoura/ProB_src/src/b_interpreter.pl between lines 2059-2069
*     
*     Unknown message sent to object: custom_explicit_sets::b_test_closure/6
*       while compiling object b_interpreter
*       in file /Users/pmoura/ProB_src/src/b_interpreter.pl between lines 2163-2180
*     
*     Unknown message sent to object: error_manager::throw_error/3
*       while compiling object b_interpreter
*       in file /Users/pmoura/ProB_src/src/b_interpreter.pl between lines 2718-2723
*     Unknown message sent to object: b_interpreter::lazy_compute_expression/7
*       while compiling object b_interpreter_check
*       in file /Users/pmoura/ProB_src/src/b_interpreter_check.pl between lines 258-261
*     
*     Unknown message sent to object: b_interpreter::parameter_list_cardinality/2
*       while compiling object b_interpreter_check
*       in file /Users/pmoura/ProB_src/src/b_interpreter_check.pl between lines 532-535
*     
*     Unknown message sent to object: kernel_objects::unbound_value/1
*       while compiling object b_interpreter_check
*       in file /Users/pmoura/ProB_src/src/b_interpreter_check.pl between lines 713-739
*     Unknown message sent to object: b_interpreter::b_compute_expressions/5
*       while compiling object b_interpreter_eventb
*       in file /Users/pmoura/ProB_src/src/b_interpreter_eventb.pl between lines 313-317
*     
*     Unknown message sent to object: b_interpreter::b_assign_values_or_functions/7
*       while compiling object b_interpreter_eventb
*       in file /Users/pmoura/ProB_src/src/b_interpreter_eventb.pl between lines 313-317
*     
*     Unknown message sent to object: b_interpreter::b_execute_becomes_such/7
*       while compiling object b_interpreter_eventb
*       in file /Users/pmoura/ProB_src/src/b_interpreter_eventb.pl between lines 328-331
*     Unknown message sent to object: b_interpreter_check::arithmetic_op/4
*       while compiling object b_ast_cleanup
*       in file /Users/pmoura/ProB_src/src/b_ast_cleanup.pl between lines 2268-2277
*     
*     Unknown message sent to object: b_interpreter::member_conjunct/3
*       while compiling object b_ast_cleanup
*       in file /Users/pmoura/ProB_src/src/b_ast_cleanup.pl between lines 2542-2544
*     Unknown message sent to object: b_operation_guards::get_variant_pred/2
*       while compiling object b_read_write_info
*       in file /Users/pmoura/ProB_src/src/b_read_write_info.pl between lines 613-617
*     Unknown message sent to object: bmachine_construction::write_section/4
*       while compiling object bmachine_eventb
*       in file /Users/pmoura/ProB_src/src/bmachine_eventb.pl between lines 742-746
*     Unknown message sent to object: custom_explicit_sets::construct_avl_set/2
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 236-240
*     
*     Unknown message sent to object: custom_explicit_sets::blocking_nr_iseq/2
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 418-422
*     
*     Unknown message sent to object: kernel_objects::mark_as_non_free/2
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 1769-1773
*     
*     Unknown message sent to object: kernel_objects::equality_objects_lwf/5
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 1829-1833
*     
*     Unknown message sent to object: b_interpreter_components::create_unsimplified_exists/3
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 2160-2166
*     
*     Unknown message sent to object: custom_explicit_sets::get_card_for_specific_custom_set/2
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 2934-2948
*     
*     Unknown message sent to object: kernel_objects::small_interval/3
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl at or above line 3558
*     
*     Unknown message sent to object: custom_explicit_sets::expand_normal_closure_direct/6
*       while compiling object bsets_clp
*       in file /Users/pmoura/ProB_src/src/bsets_clp.pl between lines 3778-3786
*     Unknown message sent to object: custom_explicit_sets::construct_less_equal_closure/2
*       while compiling object closures
*       in file /Users/pmoura/ProB_src/src/closures.pl between lines 116-117
*     Unknown message sent to object: b_interpreter::member_conjunct/3
*       while compiling object eclipse_interface
*       in file /Users/pmoura/ProB_src/src/eclipse_interface.pl between lines 996-1005
*     Unknown message sent to object: b_interpreter_components::reset_unsat_component_info/0
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 657-666
*     
*     Unknown message sent to object: b_interpreter_components::unsat_component_exists/0
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 657-666
*     
*     Unknown message sent to object: b_ast_cleanup::get_sorted_ids/2
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 1335-1341
*     
*     Unknown message sent to object: b_ast_cleanup::not_occurs_in_predicate/2
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 1335-1341
*     
*     Unknown message sent to object: b_ast_cleanup::get_sorted_ids/2
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 1342-1346
*     
*     Unknown message sent to object: translate::l_print_frozen_info/1
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 1669-1673
*     
*     Unknown message sent to object: external_functions::'PROJECT_INFO'/4
*       while compiling object eval_strings
*       in file /Users/pmoura/ProB_src/src/eval_strings.pl between lines 1754-1758
*     Unknown message sent to object: kernel_objects::unbound_variable_for_card/1
*       while compiling object kernel_cardinality_attr
*       in file /Users/pmoura/ProB_src/src/kernel_cardinality_attr.pl between lines 251-257
*     
*     Unknown message sent to object: kernel_objects::setup_ordered_list_skeleton/4
*       while compiling object kernel_cardinality_attr
*       in file /Users/pmoura/ProB_src/src/kernel_cardinality_attr.pl between lines 251-257
*     
*     Unknown message sent to object: b_interpreter_check::prop_pred_01/2
*       while compiling object kernel_cardinality_attr
*       in file /Users/pmoura/ProB_src/src/kernel_cardinality_attr.pl between lines 344-347
*     Unknown message sent to object: kernel_objects::element_of_global_set_wf/4
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 249-252
*     
*     Unknown message sent to object: custom_explicit_sets::element_of_avl_set_wf/3
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 253-255
*     
*     Unknown message sent to object: custom_explicit_sets::safe_avl_member/2
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 262-265
*     
*     Unknown message sent to object: custom_explicit_sets::is_full_id_closure/3
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 656-658
*     
*     Unknown message sent to object: custom_explicit_sets::is_very_large_maximal_global_set/2
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 824-826
*     
*     Unknown message sent to object: custom_explicit_sets::is_not_member_value_closure/3
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 829-831
*     
*     Unknown message sent to object: custom_explicit_sets::same_closure_body/6
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 835-836
*     
*     Unknown message sent to object: translate::unary_prefix/3
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 1084-1089
*     
*     Unknown message sent to object: translate::function_like/2
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 1084-1089
*     
*     Unknown message sent to object: translate::binary_infix/4
*       while compiling object kernel_mappings
*       in file /Users/pmoura/ProB_src/src/kernel_mappings.pl between lines 1090-1093
*     Unknown message sent to object: custom_explicit_sets::is_infinite_or_very_large_closure/4
*       while compiling object memoization
*       in file /Users/pmoura/ProB_src/src/memoization.pl between lines 388-396
*     
*     Unknown message sent to object: custom_explicit_sets::expand_normal_closure_direct/6
*       while compiling object memoization
*       in file /Users/pmoura/ProB_src/src/memoization.pl between lines 388-396
*     Unknown message sent to object: tcltk_interface::set_id_as_current_state/1
*       while compiling object prob2_interface
*       in file /Users/pmoura/ProB_src/src/prob2_interface.pl between lines 1306-1308
*     
*     Unknown message sent to object: bmachine::b_type_open_predicate_for_full_b_machine/6
*       while compiling object prob2_interface
*       in file /Users/pmoura/ProB_src/src/prob2_interface.pl between lines 1396-1398
*     
*     Unknown message sent to object: eval_strings::is_existential_quantifier/3
*       while compiling object prob2_interface
*       in file /Users/pmoura/ProB_src/src/prob2_interface.pl between lines 1522-1525
*     Unknown message sent to object: state_space::packed_visited_expression/2
*       while compiling object state_space_exploration_modes
*       in file /Users/pmoura/ProB_src/src/state_space_exploration_modes.pl between lines 173-176
*     Unknown message sent to object: csp_sets::member_range_expr/2
*       while compiling object csp_sequences
*       in file /Users/pmoura/ProB_src/src/cia/csp_sequences.pl between lines 218-232
*     Unknown message sent to object: haskell_csp::evaluate_argument2/2
*       while compiling object csp_tuples
*       in file /Users/pmoura/ProB_src/src/cia/csp_tuples.pl between lines 96-99
*     Unknown message sent to object: translate::translate_property_with_limit/3
*       while compiling object visualize_graph
*       in file /Users/pmoura/ProB_src/src/dot/visualize_graph.pl between lines 457-459
*     
*     Unknown message sent to object: eval_strings::repl_parse_predicate/4
*       while compiling object visualize_graph
*       in file /Users/pmoura/ProB_src/src/dot/visualize_graph.pl between lines 654-656
*     Unknown message sent to object: dpllt_settings::static_syntax_analysis/1
*       while compiling object dpllt_solver
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_solver.pl between lines 191-279
*     Unknown message sent to object: dpllt_solver::dpllt_solve_predicate/2
*       while compiling object dpllt_benchmarks
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_benchmarks.pl between lines 104-170
*     
*     Unknown message sent to object: eval_strings::repl_parse_predicate/4
*       while compiling object dpllt_benchmarks
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_benchmarks.pl between lines 209-211
*     Unknown message sent to object: bsyntaxtree::uses_an_identifier/2
*       while compiling object b_expression_sharing
*       in file /Users/pmoura/ProB_src/src/extra/b_expression_sharing.pl between lines 280-299
*     Unknown message sent to object: b_interpreter::check_nth1_invariant/2
*       while compiling object b_operation_cache
*       in file /Users/pmoura/ProB_src/src/extra/b_operation_cache.pl between lines 163-169
*     Unknown message sent to object: eval_strings::repl_parse_expression/4
*       while compiling object latex_processor
*       in file /Users/pmoura/ProB_src/src/extra/latex_processor.pl between lines 230-243
*     
*     Unknown message sent to object: eval_strings::repl_parse_substitution/2
*       while compiling object latex_processor
*       in file /Users/pmoura/ProB_src/src/extra/latex_processor.pl between lines 230-243
*     
*     Unknown message sent to object: eval_strings::last_eval_time/2
*       while compiling object latex_processor
*       in file /Users/pmoura/ProB_src/src/extra/latex_processor.pl between lines 502-505
*     Unknown message sent to object: b_interpreter::check_invariant_predicate_with_time_out/3
*       while compiling object mcdc_coverage
*       in file /Users/pmoura/ProB_src/src/extra/mcdc_coverage.pl between lines 428-440
*     Unknown message sent to object: b_interpreter_components::unsat_component_exists/0
*       while compiling object predicate_debugger
*       in file /Users/pmoura/ProB_src/src/extra/predicate_debugger.pl between lines 430-436
*     Unknown message sent to object: bmachine::get_primed_machine_variables/1
*       while compiling object ltl_tools
*       in file /Users/pmoura/ProB_src/src/ltl/ltl_tools.pl between lines 195-201
*     Unknown message sent to object: ltl_propositions::check_bop_res_patterns/4
*       while compiling object ltl_fairness
*       in file /Users/pmoura/ProB_src/src/ltl/ltl_fairness.pl between lines 186-196
*     
*     Unknown message sent to object: ltl_propositions::check_bop_arg_patterns/4
*       while compiling object ltl_fairness
*       in file /Users/pmoura/ProB_src/src/ltl/ltl_fairness.pl between lines 186-196
*     Unknown message sent to object: translate::translate_event2/3
*       while compiling object ltl_translate
*       in file /Users/pmoura/ProB_src/src/ltl/ltl_translate.pl between lines 123-129
*     Unknown message sent to object: model_checker::print_found_error/2
*       while compiling object state_space_explorer
*       in file /Users/pmoura/ProB_src/src/ltl/state_space_explorer.pl between lines 49-60
*     Unknown message sent to object: tcltk_interface::add_trans_id_with_infos/8
*       while compiling object ample_sets
*       in file /Users/pmoura/ProB_src/src/por/ample_sets.pl between lines 222-225
*     
*     Unknown message sent to object: pge_algo::get_possible_enabled_trans_names/5
*       while compiling object ample_sets
*       in file /Users/pmoura/ProB_src/src/por/ample_sets.pl between lines 247-254
*     
*     Unknown message sent to object: pge_algo::check_timeout_result/4
*       while compiling object ample_sets
*       in file /Users/pmoura/ProB_src/src/por/ample_sets.pl between lines 283-290
*     Unknown message sent to object: b_interpreter::b_execute_inner_statement/7
*       while compiling object enable_graph
*       in file /Users/pmoura/ProB_src/src/por/enable_graph.pl between lines 208-209
*     
*     Unknown message sent to object: b_interpreter::b_execute_statement/6
*       while compiling object enable_graph
*       in file /Users/pmoura/ProB_src/src/por/enable_graph.pl between lines 219-220
*     Unknown message sent to object: weakest_preconditions::create_members/3
*       while compiling object enabling_predicates
*       in file /Users/pmoura/ProB_src/src/por/enabling_predicates.pl between lines 142-168
*     Unknown message sent to object: enable_graph::vertices_edges_predicates_to_egraph/3
*       while compiling object static_analysis
*       in file /Users/pmoura/ProB_src/src/por/static_analysis.pl between lines 377-383
*     Unknown message sent to object: bmachine_eventb::is_primed_id/1
*       while compiling object synthesis_util
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_util.pl between lines 938-958
*     
*     Unknown message sent to object: bmachine::b_get_named_machine_set/3
*       while compiling object synthesis_util
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_util.pl between lines 1588-1594
*     Unknown message sent to object: b_synthesis::location_vars_to_program/9
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 29-37
*     
*     Unknown message sent to object: b_synthesis::prepare_synthesis_of_action_by_examples/10
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 123-129
*     
*     Unknown message sent to object: b_synthesis::synthesis_from_examples/18
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 123-129
*     
*     Unknown message sent to object: b_synthesis::start_specific_synthesis/7
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 131-136
Joshua27 commented 2 years ago

This issue has been solved for the modules concerning program synthesis and SMT solving:

*     Unknown message sent to object: dpllt_settings::static_syntax_analysis/1
*       while compiling object dpllt_solver
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_solver.pl between lines 191-279
*     Unknown message sent to object: dpllt_solver::dpllt_solve_predicate/2
*       while compiling object dpllt_benchmarks
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_benchmarks.pl between lines 104-170
*     
*     Unknown message sent to object: eval_strings::repl_parse_predicate/4
*       while compiling object dpllt_benchmarks
*       in file /Users/pmoura/ProB_src/src/dpllt_solver/dpllt_benchmarks.pl between lines 209-211
*     Unknown message sent to object: bmachine_eventb::is_primed_id/1
*       while compiling object synthesis_util
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_util.pl between lines 938-958
*     
*     Unknown message sent to object: bmachine::b_get_named_machine_set/3
*       while compiling object synthesis_util
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_util.pl between lines 1588-1594
*     Unknown message sent to object: b_synthesis::location_vars_to_program/9
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 29-37
*     
*     Unknown message sent to object: b_synthesis::prepare_synthesis_of_action_by_examples/10
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 123-129
*     
*     Unknown message sent to object: b_synthesis::synthesis_from_examples/18
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 123-129
*     
*     Unknown message sent to object: b_synthesis::start_specific_synthesis/7
*       while compiling object synthesis_tests
*       in file /Users/pmoura/ProB_src/src/synthesis/synthesis_tests.pl between lines 131-136