hhu-stups / prob-issues

ProB issues (for probcli, ProB Tcl/Tk, ProB2, ProB2UI)
6 stars 0 forks source link

Warnings when doing Trace Replay #344

Closed leuschel closed 5 months ago

leuschel commented 5 months ago

The warnings during trace replay in ProB2-UI should not be shown as a separate dialog, but in the main trace replay dialog. Also, there seems to be no difference between the accept and discard buttons?

Finally, one cannot copy the message in the second warning dialog.

leuschel commented 5 months ago
Screenshot 2024-03-28 at 18 50 45
leuschel commented 5 months ago

First dialog:

Screenshot 2024-03-28 at 18 53 00
leuschel commented 5 months ago

The Warning about the model should probably also only be shown when trace replay fails.

yutak001 commented 5 months ago

I added a context menu to the message cell so error messages can be copied to the system clipboard.

As for the discard/accept buttons: When I am using these buttons discard leaves the history as it is whereas accept replaces the currently used trace in the history view by the corrected version of the trace replay. The replacing process seems to take a while, at least in some cases.

leuschel commented 5 months ago

Maybe we should rename "Accept" to "Partial Replay" and Discard to "Cancel"?

yutak001 commented 5 months ago

I'm not sure if that is clear enough. I added a question label to explain the function of these buttons Screenshot_20240404_164818 How about that?

leuschel commented 5 months ago

That is good. Just it ist not entirely clear what discard means: delete the trace file and remove it from the project, remove the trace from the project, or not replay the partially replayed trace but keep it. I always thought it was the latter (as a user can always remove a trace by other means).

iTitus commented 5 months ago

It will not change the project, just the current history (trace). Discard leaves everything as it was before.

leuschel commented 5 months ago

Good. Then I would use cancel rather than discard for the button (cancel implies things stay the same for the user; discard implies we throw something away) and say something like "Do you want to perform the partial/imperfect trace replay?"

yutak001 commented 5 months ago

I renamed the discard button and added the status of the trace replay to the question Screenshot_20240405_111119