search

hhuijser / evp-portlet-upgrade

0 stars 0 forks source link

SourceFormatter report for branch test0106 #13

Closed lugbot closed 3 years ago

lugbot commented 3 years ago

Found 34 formatting issues

AppendCheck

Issues - Combine the literal strings 'exportRecordSet' and '('': [record_set_action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_lists/record_set_action.jsp#L88) - Combine the literal strings 'copyStructure' and '('': [structure_action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/structure_action.jsp#L94) - Combine the literal strings 'copyTemplate' and '('': [template_action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/template_action.jsp#L69) - Combine the literal strings 'importCalendar' and '('': [calendar_action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/calendar-portlet/calendar_action.jsp#L62) - Combine the literal strings 'exportKaleoProcess' and '('': [kaleo_process_action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/kaleo-forms-portlet/admin/kaleo_process_action.jsp#L51)

GetterUtilCheck, click here for documentation

Issues - No need to pass default value 'StringPool.BLANK': [configuration.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/configuration.jsp#L24) - No need to pass default value 'false': [init.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/init.jsp#L190) - No need to pass default value '0': [edit_ldap_server.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/edit_ldap_server.jsp#L23) - No need to pass default value '0': [test_ldap_connection.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_connection.jsp#L20) - No need to pass default value '0': [test_ldap_groups.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_groups.jsp#L20) - No need to pass default value '0': [test_ldap_users.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_users.jsp#L20) - No need to pass default value '0': [edit_item.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/shopping/edit_item.jsp#L281) - No need to pass default value 'StringPool.BLANK': [page.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/asset_tags_summary/page.jsp#L23) - No need to pass default value '0': [init.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/calendar-portlet/init.jsp#L150) - No need to pass default value 'StringPool.BLANK': [configuration.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/configuration.jsp#L20) - No need to pass default value 'StringPool.BLANK': [configuration.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/configuration.jsp#L21) - No need to pass default value 'StringPool.BLANK': [edit_field.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp#L23) - No need to pass default value 'StringPool.BLANK': [edit_field.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp#L28) - No need to pass default value 'StringPool.BLANK': [edit_field.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp#L32)

JSPFileNameCheck, click here for documentation

Issues - Do not use '-' in file name: https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/common/themes/bottom-test.jsp - Do not use '-' in file name: https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/aui/init-alloy.jspf

JSPLineBreakCheck

Issues - Incorrect line break: [ckconfig_bbcode.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor/ckconfig_bbcode.jsp#L54) - Incorrect line break: [ckconfig_creole.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor/ckconfig_creole.jsp#L52) - Incorrect line break: [ckconfig_bbcode.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_diffs/ckconfig_bbcode.jsp#L54) - Incorrect line break: [ckconfig_creole.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_diffs/ckconfig_creole.jsp#L52) - Incorrect line break: [ckconfig_bbcode.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest/ckconfig_bbcode.jsp#L54) - Incorrect line break: [ckconfig_creole.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest/ckconfig_creole.jsp#L52) - Incorrect line break: [ckconfig_bbcode.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest_diffs/ckconfig_bbcode.jsp#L54) - Incorrect line break: [ckconfig_creole.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest_diffs/ckconfig_creole.jsp#L52)

JSPStylingCheck

Issues - There should be a line break after '}': [view_article.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal/view_article.jsp#L60) - There should be a line break after '}': [view.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal_articles/view.jsp#L280)

LocalVariableNameCheck, click here for documentation

Issues - Local non-final variable 'CELLS_PER_ROW' must match pattern '^[a-z0-9][_a-zA-Z0-9]*$': [configuration.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/nested_portlets/configuration.jsp#L31)