search

hhuijser / evp-portlet-upgrade

0 stars 0 forks source link

Add lugbot.yaml #131

Closed hhuijser closed 3 years ago

lugbot commented 3 years ago

Found 2 Issues for Check 'JSPStylingCheck'

JSPStylingCheck

Issues - There should be a line break after '}': [/view_article.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal/view_article.jsp#L60) - There should be a line break after '}': [/view.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal_articles/view.jsp#L280)
lugbot commented 3 years ago

Found 27 Issues for Category 'Bug Prevention'

ValidatorIsNullCheck

Issues - Method 'Validator.isNull' should only be used for type 'Long', 'Serializable' or 'String': [/ckeditor.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor.jsp#L346)

JSPIllegalSyntaxCheck, click here for documentation

Issues - Do not use console.log: [/action.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portal/api/jsonws/action.jsp#L594)

JSPTagAttributesCheck

Issues - There should be a line break after '

ValidatorIsNullCheck

Issues - Method 'Validator.isNull' should only be used for type 'Long', 'Serializable' or 'String': [/actions.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portal/api/jsonws/actions.jsp#L66) - Method 'Validator.isNotNull' should only be used for type 'Long', 'Serializable' or 'String': [/look_and_feel_themes.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/layouts_admin/look_and_feel_themes.jsp#L74) - Method 'Validator.isNotNull' should only be used for type 'Long', 'Serializable' or 'String': [/modified.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/search/facets/modified.jsp#L125) - Method 'Validator.isNotNull' should only be used for type 'Long', 'Serializable' or 'String': [/modified.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/search/facets/modified.jsp#L134) - Avoid using method 'Validator.isNotNull(long)': [/open_search.jspf](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/search/open_search.jspf#L177) - Avoid using method 'Validator.isNotNull(long)': [/last_publication_date_message.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/staging_bar/last_publication_date_message.jsp#L95) - Avoid using method 'Validator.isNotNull(long)': [/last_publication_date_message.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/staging_bar/last_publication_date_message.jsp#L103) - Method 'Validator.isNull' should only be used for type 'Long', 'Serializable' or 'String': [/page.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/asset_links/page.jsp#L56) - Method 'Validator.isNull' should only be used for type 'Long', 'Serializable' or 'String': [/page.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/categorization_filter/page.jsp#L25) - Method 'Validator.isNotNull' should only be used for type 'Long', 'Serializable' or 'String': [/page.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/progress/page.jsp#L33)

XMLBuildFileCheck

Issues - Incorrect order 'target': 'ZIPDIRNAME_CHECK' should come after 'zip-true': [/build.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/opensocial-portlet/gadget/js/OpenAjax_Hub_2.0.5_r1293/build.xml) - Incorrect order 'target': 'release_unmanagedhub' should come after 'help': [/build.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/opensocial-portlet/gadget/js/OpenAjax_Hub_2.0.5_r1293/build.xml) - Incorrect order 'target': 'zip-true' should come after 'zip-false': [/build.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/opensocial-portlet/gadget/js/OpenAjax_Hub_2.0.5_r1293/build.xml) - Target 'standalone_test' does not exist: [/build.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/opensocial-portlet/gadget/js/OpenAjax_Hub_2.0.5_r1293/build.xml)

XMLServiceEntityNameCheck, click here for documentation

Issues - Do not use entity 'Calendar' when package is 'com.liferay.calendar': [/service.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/calendar-portlet/WEB-INF/service.xml)

XMLServiceFileCheck

Issues - Incorrect order 'KaleoTimerInstanceToken#KITI_C_B#finder-column': 'completed' should come after 'blocking': [/service.xml](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/kaleo-web/WEB-INF/service.xml)
lugbot commented 3 years ago

Found 26 Issues for Category 'Performance'

MapIterationCheck, click here for documentation

Issues - Use Map.entrySet() to retrieve values: [/actions.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portal/api/jsonws/actions.jsp#L75) - Use Map.entrySet() to retrieve values: [/asset_selection.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/asset_selection.jsp#L146) - Use Map.entrySet() to retrieve values: [/view.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/control_panel_home/view.jsp#L25) - Use Map.entrySet() to retrieve values: [/view.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/control_panel_menu/view.jsp#L45) - Use Map.entrySet() to retrieve values: [/look_and_feel_themes.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/layouts_admin/look_and_feel_themes.jsp#L143) - Use Map.entrySet() to retrieve values: [/view.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/social_activity/view.jsp#L46)

StringCastCheck

Issues - No need to call '.toString()' on type String: [/render_portlet.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portal/render_portlet.jsp#L591) - No need to call '.toString()' on type String: [/facebook.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/login/navigation/facebook.jsp#L45)

UnnecessaryTypeCastCheck

Issues - No need to apply Type Cast to method 'groups.get': [/edit_role_permissions_resource.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/roles_admin/edit_role_permissions_resource.jsp#L131) - No need to apply Type Cast to method 'portlets.get': [/open_search.jspf](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/search/open_search.jspf#L69) - No need to apply Type Cast to method 'portlets.get': [/open_search.jspf](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/search/open_search.jspf#L99) - No need to apply Type Cast to method 'results.get': [/page_iterator.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/wiki/page_iterator.jsp#L379) - No need to apply Type Cast to method 'messages.get': [/page.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/discussion/page.jsp#L231)

ValidatorEqualsCheck, click here for documentation

Issues - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/ckeditor_bbcode.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_bbcode.jsp#L24) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/ckeditor_creole.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_creole.jsp#L24) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/edit_query_rule.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/edit_query_rule.jsp#L37) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/view_entry_content.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/blogs/view_entry_content.jsp#L170) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/edit_template.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/edit_template.jsp#L63) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/edit_template_display.jspf](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/edit_template_display.jspf#L633) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/publish_process_message.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/layouts_admin/publish_process_message.jsp#L57) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/publish_process_message.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/layouts_admin/publish_process_message.jsp#L89) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/publish_process_message.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/layouts_admin/publish_process_message.jsp#L92) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/display_settings.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/display_settings.jsp#L139) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/display_settings.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/display_settings.jsp#L166) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/display_settings.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/display_settings.jsp#L199) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/display_settings.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0422_2/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/display_settings.jsp#L203)