search

hhuijser / evp-portlet-upgrade

0 stars 0 forks source link

SourceFormatter issue #9

Closed lugbot closed 3 years ago

lugbot commented 3 years ago

Found 31 formatting issues

AppendCheck violations - Combine the literal strings 'exportRecordSet' and '('': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_lists/record_set_action.jsp 88 (Checkstyle:AppendCheck) - Combine the literal strings 'copyStructure' and '('': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/structure_action.jsp 94 (Checkstyle:AppendCheck) - Combine the literal strings 'copyTemplate' and '('': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/dynamic_data_mapping/template_action.jsp 69 (Checkstyle:AppendCheck) - Combine the literal strings 'importCalendar' and '('': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/calendar-portlet/calendar_action.jsp 62 (Checkstyle:AppendCheck) - Combine the literal strings 'exportKaleoProcess' and '('': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/kaleo-forms-portlet/admin/kaleo_process_action.jsp 51 (Checkstyle:AppendCheck)

GetterUtilCheck, click here for documentation

Issues - No need to pass default value 'StringPool.BLANK': [configuration.jsp](https://github.com/hhuijser/evp-portlet-upgrade/blob/test0106//liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/configuration.jsp#L24) - No need to pass default value 'false', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/asset_publisher/init.jsp 190 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/edit_ldap_server.jsp 23 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_connection.jsp 20 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_groups.jsp 20 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/portal_settings/test_ldap_users.jsp 20 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/shopping/edit_item.jsp 281 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/taglib/ui/asset_tags_summary/page.jsp 23 (SourceCheck:GetterUtilCheck) - No need to pass default value '0', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/calendar-portlet/init.jsp 150 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/configuration.jsp 20 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/configuration.jsp 21 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp 23 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp 28 (SourceCheck:GetterUtilCheck) - No need to pass default value 'StringPool.BLANK', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/getter_util_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/web-form-portlet/edit_field.jsp 32 (SourceCheck:GetterUtilCheck)
JSPFileNameCheck violations - Do not use '-' in file name, see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/jsp_file_name_check.markdown: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/common/themes/bottom-test.jsp (SourceCheck:JSPFileNameCheck)
JSPLineBreakCheck violations - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor/ckconfig_bbcode.jsp 54 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor/ckconfig_creole.jsp 52 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_diffs/ckconfig_bbcode.jsp 54 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_diffs/ckconfig_creole.jsp 52 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest/ckconfig_bbcode.jsp 54 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest/ckconfig_creole.jsp 52 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest_diffs/ckconfig_bbcode.jsp 54 (SourceCheck:JSPLineBreakCheck) - Incorrect line break: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/js/editor/ckeditor_latest_diffs/ckconfig_creole.jsp 52 (SourceCheck:JSPLineBreakCheck)
JSPStylingCheck violations - There should be a line break after '}': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal/view_article.jsp 60 (SourceCheck:JSPStylingCheck) - There should be a line break after '}': /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/journal_articles/view.jsp 280 (SourceCheck:JSPStylingCheck)
LocalVariableNameCheck violations - Local non-final variable 'CELLS_PER_ROW' must match pattern '^[a-z0-9][_a-zA-Z0-9]*$', see https://checkstyle.sourceforge.io/config_naming.html#LocalVariableName: /tmp/evp-portlet-upgrade_9192497648167331788/liferay-portal-6.2-ee-sp20/tomcat-7.0.62/webapps/ROOT/html/portlet/nested_portlets/configuration.jsp 31 (Checkstyle:LocalVariableNameCheck)