search

hhunaid / react-native-image-crop-tools

Native-ish Image Crop Tools for react native
171 stars 58 forks source link

do not zoom-in when rotating image on iOS #57

Closed efstathiosntonas closed 2 years ago

efstathiosntonas commented 2 years ago

When rotating image on iOS the image was zooming-in causing a bad UX.

I've added a new boolean prop aspectRatioLockDimensionSwapEnabled, it's the name TOCropViewController is using, we could make it shorter/better.

related issue: https://github.com/hhunaid/react-native-image-crop-tools/issues/21

Before the patch:

https://user-images.githubusercontent.com/717975/142637772-d24864d6-3c5c-4e51-a745-4b5b208bd5ca.MP4

After the patch:

https://user-images.githubusercontent.com/717975/142639778-82664b34-925f-43cc-a6bf-1dbfda249215.MP4

efstathiosntonas commented 2 years ago

@hhunaid just saw that another patch of mine has slipped in, creating a new commit now without it. Sorry

efstathiosntonas commented 2 years ago

@hhunaid can you please merge this PR and the example one? Thanks!