hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.61k stars 505 forks source link

Refactor of _utils.py and associated test cases #1031

Closed jknndy closed 3 months ago

jknndy commented 3 months ago

_utils.py

library/test_utils.py

jayaddison commented 3 months ago

Updated get_host_name to use .get

This change I'm a little skeptical of - it's an unusual case where I think we'd want the code to break and let us know about it if the host info isn't available. What do you reckon?

jayaddison commented 3 months ago

Generally looks great, thanks again!

Maybe add 'closes #1004' or 'resolves #1004' to the pull request description to auto-close that bug on merge?

jknndy commented 3 months ago

Maybe add 'closes #1004' or 'resolves #1004' to the pull request description to auto-close that bug on merge?

This actually isn't resolved in this update. The FRACTIONS adjustments are only represented in the get_minutes function where the issue in #1004 is related to the ingredients and instructions print outs. Still worth including but I will remove mention of the issue from the PR outline.