Closed jknndy closed 3 months ago
Updated
get_host_name
to use .get
This change I'm a little skeptical of - it's an unusual case where I think we'd want the code to break and let us know about it if the host
info isn't available. What do you reckon?
Generally looks great, thanks again!
Maybe add 'closes #1004' or 'resolves #1004' to the pull request description to auto-close that bug on merge?
Maybe add 'closes #1004' or 'resolves #1004' to the pull request description to auto-close that bug on merge?
This actually isn't resolved in this update. The FRACTIONS adjustments are only represented in the get_minutes function where the issue in #1004 is related to the ingredients and instructions print outs. Still worth including but I will remove mention of the issue from the PR outline.
_utils.py
FRACTIONS
coverage andTIME_REGEX
readability_extract_fractional
coverage capabilities. Now handling a wider range of fractional representations specifically unicode fraction characters.1⅔
by iterating through theFRACTIONS
dictionary to find matches & processing separately as needed.FRACTIONS
for a match to replace unicode charactersValueError
with a descriptive error message for unrecognized fraction inputs.get_minutes
for readability and adjusted for new functionality from_extract_fractional
url_path_to_dict
get_host_name
to use .getchange_keys
convert
to keys.str
,int
,float
,set
, andtuple
library/test_utils.py
get_minutes
tests into consolidated test cases withinTestUtilsRefactored
test_minutes_fixtures
test_iso8601_fixtures
setUpClass
method inTestUtilsRefactored
to allow for further testing expansion.test_list_public_methods
to dynamically list and compare public methods ofAbstractScraper