Refactor of _grouping_utils and associated test case updates - Githubissues

hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.61k stars 505 forks source link

Refactor of _grouping_utils and associated test case updates #1033

Closed jknndy closed 3 months ago

jknndy commented 3 months ago

_grouping_utils/score_sentence_similarity

Adjusted comments to outline more detail about what is completed in this function and relocate some comments.
Some quick code cleanups and relocated the len() function for calculating the intersection size to the line where intersection is defined for a slight readability update

_grouping_utils/best_match

Adjusted comments to outline more detail about what is completed in this function
Refined the strategy for identifying the best match index by using a key function for comparision

_grouping_utils/group_ingredients

Updated some of the comments to add context
Changed some variable names for readability

tests/_grouping__utils.py

Added tests covering other possible inputs