search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.61k stars 505 forks source link

Extruct breaking due to lxml breakage #1045

Closed disconsented closed 3 weeks ago

disconsented commented 3 months ago

I'd been running into the issue described here https://github.com/scrapinghub/extruct/issues/215

Adding lxml>=5.0.0,<5.1.0 to requirements-dev.txt and reinstalling via pip resolved this issue for me.

jayaddison commented 3 months ago

Thanks @disconsented :+1:

A question / possible adjustment: is there a reason to exclude v5.1.0 in the version range? I think the breaking change introduced here was in v5.1.1 of lxml (eba79343d0e7ad1ce40169f60460cdd4caa29eb3).

jtcimba commented 2 months ago

Confirming that uninstalling and reinstalling with @disconsented 's specified versions worked for me

michael-genson commented 1 month ago

FYI - there is a new version of extruct out which fixes this