Development dependencies: limit to extruct-0.16-compatible lxml.

hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.61k stars 505 forks source link

Development dependencies: limit to extruct-0.16-compatible lxml. #1048

Closed jayaddison closed 3 months ago

jayaddison commented 3 months ago

The version-range applied here excludes v5.1.1 of lxml, where removal of a non-unicode string type in https://github.com/lxml/lxml/commit/eba79343d0e7ad1ce40169f60460cdd4caa29eb3 causes problems for v0.16 of extruct. The version-range is applied for development dependencies (continuous integration, local development).

Ref: https://github.com/scrapinghub/extruct/issues/215

Relates to #1045 (but does not resolve it).

jknndy commented 3 months ago

Hey @jayaddison, i'm going to go ahead and merge this so i can rerun / merge some of the other open PRs as well as open a new one. Thanks for the fix!