hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.61k stars 505 forks source link

HalfBakedHarvest Scraper missing some functions #1050

Closed mkierzenka closed 3 months ago

mkierzenka commented 3 months ago

Great project :) Thank you to the team/contributors! I'm using this in a personal project for uploading recipes to Notion. It seems the tool is missing support for a few fields for HalfBakedHarvest pages, especially prep_time and cook_time, so I have gone ahead and added them. I also extended the tests to cover the new additions.

I tried to follow the developer docs but please let me know if I missed anything!

Pre-filing checks

The URL of the recipe(s) that are not being scraped correctly

The results you expect to see A numerical output from scraper.prep_time() and scraper.cook_time().

The results (including any Python error messages) that you are seeing An exception, NotImplementedError: This should be implemented.

File "/usr/local/lib/python3.11/site-packages/recipe_scrapers/_abstract.py", line 91, in prep_time
    raise NotImplementedError("This should be implemented.")