search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.7k stars 518 forks source link

Add KitchenAid Australia #1058

Closed mlduff closed 5 months ago

mlduff commented 5 months ago

This PR adds support for KitchenAid Australia recipes. There was some Recipe schema support, however only for basic metadata. Ingredients, instructions, time and yield were all scraped manually.

total_time() was particularly difficult, as across different recipes there are different fields for time. The approach I took was to get all the time related fields from the summary and then use the last one as the total, which was the case in all the recipes I checked. If you think it is necessary I'm happy to add some test cases for this.

Resolves #1057

mlduff commented 5 months ago

@jayaddison comments should be all addressed now :)

mlduff commented 5 months ago

Thanks @jayaddison - is there anything else I have to do to get this merged?

jayaddison commented 5 months ago

@mlduff nope, other than waiting for me to get around to merging the changes :) Thank you!