Adds keywords as a possible output

hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.7k stars 518 forks source link

Adds keywords as a possible output #1059

Closed jknndy closed 5 months ago

jknndy commented 5 months ago

Resolves https://github.com/hhursev/recipe-scrapers/issues/349

Adds keywords as a possible output

smilerz commented 5 months ago

@jknndy thanks for completing the PR on my request!

@jayaddison will this also be merged into v15?

jayaddison commented 5 months ago

@jayaddison will this also be merged into v15?

@smilerz I expect so, yep - there is a merge conflict with #1107, so I think I'll wait until we can resolve that and then merge both into v15 because they are similar.

jayaddison commented 5 months ago

@jknndy I'm not sure this is quite ready for release unfortunately; there are two problems I've found:

We haven't documented it (easy enough to fix).
The behaviour of only returning a single item from the keywords when it is found as a list seems inconsistent -- and the obvious fix for that, returning the entire list, produces a bunch of spammy results.

I'm planning to open a revert PR for this (some merge conflicts, so may take a little while).