search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.61k stars 505 forks source link

Add support for thecookingguy.com #1067

Closed rmdluo closed 1 month ago

rmdluo commented 2 months ago

This PR adds support for thecookingguy.com, using https://www.thecookingguy.com/recipes/chili-cumin-lamb as the test case.

Resolves #957

jknndy commented 2 months ago

Great start! The site_name should be returned by the schema as the expected key, I tested it locally and the scraper is expected Sam The Cooking Guy, answering #957 here to consolidate the discussion.

edit: I was mistaken! For instances where site_name is not automatically populating you can define it by adding a declaration to the scraper class, like this...

    def site_name(self):
        return "Sam The Cooking Guy"

note: should the description of this PR read thecookingguy.com instead of bestrecipes.com.au?

rmdluo commented 2 months ago

Oh yes, sorry about that I copied and pasted from another one so I could get the format right

jknndy commented 2 months ago

@rmdluo , as this has been under active development let me know when you're ready for a review!

rmdluo commented 2 months ago

I think we're ready for review now!

rmdluo commented 2 months ago

Oops wait forgot to add it to the list of websites on the readme

jayaddison commented 2 months ago

Oops wait forgot to add it to the list of websites on the readme

Good catch :smile: