Refactor: consistency: use a separate scraper classname per brandname.

hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.6k stars 505 forks source link

Refactor: consistency: use a separate scraper classname per brandname. #1118

Closed jayaddison closed 1 month ago

jayaddison commented 2 months ago

The idea for this refactor originates from code-review of #1116.

There are two motivations:

Selection of a scraper should be possible based on the origin URL as input (this was already catered-for).
Domain names and brands can be merged/acquired over time, so if two sites appear distinct in the view of a typical consumer -- even if they are known to be owned by the same entity, and present the same content -- then we should retain different scraper classes for each of them. Internally they may re-use implementation (as is the case here).

jayaddison commented 2 months ago

Thanks! As far as I know, this is the only case where the entire domain is replaced (as opposed the addition of different TLD suffixes / subdomain prefixes). Or maybe I misunderstood?

jknndy commented 1 month ago

Thanks! As far as I know, this is the only case where the entire domain is replaced (as opposed the addition of different TLD suffixes / subdomain prefixes). Or maybe I misunderstood?

I was thinking about #1075 , in the listed example URLs there are 3 different domains. I wonder if something similar could be implemented? i'll look into it once this is merged.

jayaddison commented 1 month ago

Thanks! As far as I know, this is the only case where the entire domain is replaced (as opposed the addition of different TLD suffixes / subdomain prefixes). Or maybe I misunderstood?

I was thinking about #1075 , in the listed example URLs there are 3 different domains. I wonder if something similar could be implemented? i'll look into it once this is merged.

Ah, good catch :) Yep, that sounds good to me. Thanks!