hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.6k stars 505 forks source link

JamieOliver: typo in image retrieval method #1126

Closed jayaddison closed 1 month ago

jayaddison commented 1 month ago

Pre-filing checks

The URL of the recipe(s) that are not being scraped correctly

The results you expect to see

The image value expectation in the test data seems incorrect here; the code looks intended to retrieve data from schema.org, but because of the typo in the method name, it raises an exception and uses a plugin fallback during the unit tests.

The results (including any Python error messages) that you are seeing

After fixing the typo:

AssertionError: 'https://cdn.jamieoliver.com/recipe-database/oldIm[27 chars].jpg' != 'https://img.jamieoliver.com/jamieoliver/recipe-da[53 chars]-800'
- https://cdn.jamieoliver.com/recipe-database/oldImages/medium/88_1_1441269331.jpg
?         ^^^                                           ^ ----
+ https://img.jamieoliver.com/jamieoliver/recipe-database/oldImages/large/88_1_1441269331.jpg?tr=w-800,h-800
?         ^^^                ++++++++++++                           ^^^^                     +++++++++++++++
 : The actual value for .image() did not match the expected value.