hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.6k stars 505 forks source link

5 site additions #1133

Closed jknndy closed 1 month ago

jknndy commented 1 month ago
jayaddison commented 1 month ago

These look good to me - I'm going to take a second look in a few hours to re-confirm.

Out of interest, was it easier/more-difficult/no-different to develop these scrapers without all of the self.schema.* calls in place for each field?

jayaddison commented 1 month ago

It's nitpicky, but I'd suggest that we move the ratings-count corrections into a separate pull request; that should help make the intention of both pull requests clearer (and matches the pull request title here to the changeset).

jknndy commented 1 month ago

It's nitpicky, but I'd suggest that we move the ratings-count corrections into a separate pull request; that should help make the intention of both pull requests clearer (and matches the pull request title here to the changeset).

reverted, i'll open in a new pr with those changes