Closed Mooree003 closed 4 weeks ago
This generally looks good to me, thank you @Mooree003!
Out of interest: for the ingredient_groups
implementation: we have some scrapers (rainbowplantlife.py
, vanillaandbean.py
for example) that query similar-looking HTML elements using a group_ingredients
utility function that can make the code more concise: do you know whether that approach would be re-usable here?
This generally looks good to me, thank you @Mooree003!
Out of interest: for the
ingredient_groups
implementation: we have some scrapers (rainbowplantlife.py
,vanillaandbean.py
for example) that query similar-looking HTML elements using agroup_ingredients
utility function that can make the code more concise: do you know whether that approach would be re-usable here?
The only reason was in another scraper i created this method seemed to not work as intended so I reused my previous method however the group_ingredients
works for this scraper so I will add this now
Thanks @Mooree003!
From some testing here: the cooking_method
and equipment
methods are not available on the SchemaOrg
class, so we can't use those by calling self.schema.<method-name>()
. I would recommend either removing them, or retrieving the data from the HTML where possible.
And a question / optional feature request: it looks like the recipe webpage includes nutritional info in the schema.org
metadata, so that would be a nice bonus if we can include that too.
Thanks @Mooree003!
From some testing here: the
cooking_method
andequipment
methods are not available on theSchemaOrg
class, so we can't use those by callingself.schema.<method-name>()
. I would recommend either removing them, or retrieving the data from the HTML where possible.And a question / optional feature request: it looks like the recipe webpage includes nutritional info in the
schema.org
metadata, so that would be a nice bonus if we can include that too.
Interesting I thought I removed these 😂. I'll add the nutritional info and remove the functions
:+1: all looks good to me...
...but I'm going to add one more suggestion, because even though equipment
isn't available through SchemaOrg
, there is some equipment info in the HTML, and it's not too tricky to extract. Hold on for a moment and I'll add a couple of code review comments to do that.
👍 all looks good to me...
...but I'm going to add one more suggestion, because even though
equipment
isn't available throughSchemaOrg
, there is some equipment info in the HTML, and it's not too tricky to extract. Hold on for a moment and I'll add a couple of code review comments to do that.
No worries! Added now
changes addressed
@Mooree003 , looks great thanks! merging now
This is a PR for recipe-scrapers to include recipes from jocooks. There was full schema support except for ingredient groups which had to be configured manually.
Resolves #1129