Closed jknndy closed 8 months ago
Happy Thanksgiving @jknndy! Hope you had a good time, and glad to hear that you found some recipes.
I'll take a look through these changes within the next day or two (and then I'll take another look at the huge mess of comments I left in #925).
This looks good to me :+1: Thank you @jknndy!
A few reviewer-experience comments, since this was my first review of a scraper using the new JSON test data format: this felt much easier to review; the tests are more concise and I didn't have to think as much about any edge cases that could exist in the test module (duplicate/mismatched method names, code affecting expected values, etc).
One nitpick: the duplication of instructions
as instructions_list
in the JSON file was mildly confusing, and seemed redundant. The list format seemed easier to read, when reviewing (because each line is shorter, and there aren't as many escaped characters).
cc @hay-kot @strangetom
Quick site addition today of a site that provided one of my thanksgiving dishes!
Happy Thanksgiving! Hope whoever may see this had a nice time with family/friends.