hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.66k stars 514 forks source link

Tests: performance ~~regression~~ improvement since #944 #954

Closed jayaddison closed 8 months ago

jayaddison commented 8 months ago

Pre-filing checks

The results you expect to see

Tests used to run faster than they do after the merge of #944. That's OK - the functionality there is a great improvement; but if we can speed up the tests again that could be nice too. Lies - tests are faster after #944 - even so, I'll create this issue anyway because the information could be valuable.

$ git checkout 4e0cfc6af91420da42d8648d9a00f84a61076231
HEAD is now at 4e0cfc6 Pre test refactor changes (#945)
$ time python3 -m unittest
...
Ran 4554 tests in 34.491s

OK (skipped=25, expected failures=7)

real    0m39.842s
user    0m38.707s
sys 0m0.975s

The results (including any Python error messages) that you are seeing

$ git checkout 4fc3bb33b45a19a6e9ceded611c9ac663852889f
HEAD is now at 4fc3bb3 Data driven tests refactor (#944)
$ time python3 -m unittest
...
Ran 457 tests in 26.514s

OK

real    0m27.054s
user    0m26.432s
sys 0m0.260s