search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.62k stars 508 forks source link

add support for several sites #969

Closed wassupluke closed 6 months ago

wassupluke commented 6 months ago

adds support for:

jknndy commented 6 months ago

Hi @wassupluke, thanks for the contribution! On first pass it looks like it's likely ready for merge. Just one request, could you please create an entry in the supported sites section of the Read Me file in the correct spot?

Once the entry is created I'll take one last look over & merge if ready!

Thanks & happy holidays

jknndy commented 6 months ago

@wassupluke, this all look good and I'll plan to merge into the code base this afternoon!

Just one thing to note, generally once pull request has been reviewed and approved you should avoid adding anything (except fixes or corrections if needed) to the same request, this example being support for EatLiveRun. It'd be better to add any separate changes to a new pull request so that the code doesn't need to be re-reviewed before closing it out!

wassupluke commented 6 months ago

Sounds good. That's kind of what I figured after I realized my push to my main branch updated this pull request. This is honestly my first time contributing to a project so I'm still trying to get the hang of things (I'm a nurse who self-taught git so any education is appreciated:)