search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.7k stars 521 forks source link

Recent addition updates #975

Closed jknndy closed 8 months ago

jknndy commented 9 months ago

Adds ingredient grouping support for a few sites.

@strangetom, what do you think about eliminating the second test case for ingredient grouping if the recipe covered under the first test contains grouped ingredients? See ArchanasKitchen below for an example, since its ingredient_groups is covered by default in every test case.

strangetom commented 9 months ago

Hi @jknndy. In my opinion, testing both cases (a recipe with ingredient groups and a recipe without ingredient groups) has benefits. The same code is used to extract the ingredients from the html markup for both types of recipe. The markup will be different between recipes with and without ingredient groups, so testing both cases demonstrates the scraper works for both cases.