hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.7k stars 521 forks source link

Adds support for joshuaweissman.com #979

Closed Kvan7 closed 8 months ago

Kvan7 commented 9 months ago

Some known issues that I don't have easy fixes for mainly since the site's ingredients and instructions are tagged almost identically.

Ingredients include "estimated schedules" as nothing is really tagged with nice ids or classes and the best way to get ingredients was just all ul. Probably a way to do it by detecting like if there is a time in the string?
I couldn't find a way to nicely do this site's ingredient groups.
Site itself also contains many pages that have multiple recipes in the same url. More extreme example. Not sure how to do this, so just pretending they don't exist. Still scrapes them just like becomes quite illegible.

483 #490

jayaddison commented 8 months ago

@Kvan7 one more thing - could you file a bug for each of the two known issues (ingredients list may contain schedules, some pages contain multiple recipes)?

I don't think that's a blocker, but I'd like to increase the chance that we get around to fixing it (I'll try to take another look at each of them and the HTML structure soon; your summaries of the problem make sense).

Kvan7 commented 8 months ago

Issues have been created #983, #984. Would you like me to make an issue for the ingredients groups being rarely wrong as well?

jayaddison commented 8 months ago

Thanks @Kvan7 - and oops, my mistake forgetting about the ingredient grouping / section heading problem. It seemed slightly less important to me because ingredients (non-grouped) should still be available and only for a single known recipe.. but for consistency, yes, let's keep a note about that too (useful when me or anyone else gets around to attempting possible fixups).

Kvan7 commented 8 months ago

Added that issue #985, I may look at it a bit as well if i have more time

jayaddison commented 8 months ago

Thank you!