hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.62k stars 508 forks source link

mob.co.uk: empty ingredient groups for recipes that don't have ingredient section headings #987

Closed jayaddison closed 5 months ago

jayaddison commented 6 months ago

Pre-filing checks

The URL of the recipe(s) that are not being scraped correctly

The results you expect to see

Although not all recipes provide groupings/section headings for the ingredients, we do want the output of scraper.ingredient_groups to include a complete list of ingredients in all cases.

That means that for recipes without grouped ingredients, there should be a single placeholder grouping with purpose=None.

(there's some further information on this in the ingredient group developer documentation)

The results (including any Python error messages) that you are seeing

Calling the .ingredient_groups() method on the scraper produces an empty list.

cc @jacksgreen

jacksgreen commented 5 months ago

@jayaddison I've create a pull request fixing this issue

jayaddison commented 5 months ago

Thanks @jacksgreen! I've added one suggested edit; apart from that it looks good - it'll be nice to have this fixed.