search

hhursev / recipe-scrapers

Python package for scraping recipes data
MIT License
1.62k stars 508 forks source link

Cleanup: apply a few py3.8+ cleanups based on suggestions by pyupgrade #995

Closed jayaddison closed 5 months ago

jayaddison commented 5 months ago

Miscellaneous small cleanups.

hhursev commented 5 months ago

pyupgrade is nice! I think we should add it as .pre-commit-config hook, thoughts?

jayaddison commented 5 months ago

pyupgrade is nice! I think we should add it as .pre-commit-config hook, thoughts?

I think that makes sense, yep - one note is that it's best to tell pyupgrade what the baseline Python version is for the codebase when it runs, so we'll want to update that version occasionally.

jayaddison commented 5 months ago

(I'll add an edit for the .pre-commit-config.yaml file in this same branch?)

hhursev commented 5 months ago

I'd do same branch yep

hhursev commented 5 months ago

nvm saw you did. this looks good to me. squash merge whenever you feel like