cleanup: remove redundant additional dependencies from pre-commit config

hhursev / recipe-scrapers

Python package for scraping recipes data

MIT License

1.62k stars 508 forks source link

cleanup: remove redundant additional dependencies from pre-commit config #997

Closed jayaddison closed 5 months ago

jayaddison commented 5 months ago

These are included as development requirements, as installed by tox (for example, during tox -e lint).

jayaddison commented 5 months ago

Ok; this was a misunderstanding on my behalf about the way that tox environments interact. It seems that the lint env does not share the base env's dependencies.

I wanted to avoid duplicating the list of types-* package dependencies in two places, but for now I think it's OK to continue as-is, and I'll close this PR.

I did consider adding the --install-types argument that can be used when running mypy as a standalone program, but the mypy pre-commit README warns against that.