hhvm / hack-codegen

Library to programatically generate Hack code and write it to signed files
https://hhvm.github.io/hack-codegen/
MIT License
341 stars 93 forks source link

Facebookism: directories created mode 0777 #11

Closed fredemmott closed 7 years ago

fredemmott commented 8 years ago

https://github.com/facebook/hack-codegen/blob/master/src/CodegenFile.php#L413

This makes sense if running in the context of the webserver, but is bad for normal cases. This definitely shouldn't be the default.

fredemmott commented 7 years ago

Not really an issue, pays attention to umask.