search

hhvm / hack-codegen

Library to programatically generate Hack code and write it to signed files
https://hhvm.github.io/hack-codegen/
MIT License
341 stars 93 forks source link

fix HackfmtFormatter #129

Closed jjergus closed 4 years ago

jjergus commented 4 years ago

Using weird random strings seems a bit hacky but it's basically what SignedSource does to handle signing, so at least it's consistent with that ¯_(ツ)_/¯

fredemmott commented 4 years ago

Alternative: https://github.com/facebook/hhvm/commit/2b0c783925081d5775cfa876e9ef1ab992810a29

jjergus commented 4 years ago

Yep that is nicer, we'll just need to wait for the next release then.

jjergus commented 4 years ago

Yes, much better.