hhvm / hack-codegen

Library to programatically generate Hack code and write it to signed files
https://hhvm.github.io/hack-codegen/
MIT License
341 stars 93 forks source link

Fix fixmes for variadics #25

Closed fredemmott closed 7 years ago

fredemmott commented 7 years ago
/* HH_FIXME[4033] variadic params with type constraints are not supported */

Given that 3.12 support has been dropoped, these can all be cleaned up

simonwelsh commented 7 years ago

hh_client --remove-dead-fixmes will do this for you

fredemmott commented 7 years ago

TIL, thanks - though still lots of manual work because:

fredemmott commented 7 years ago

:/ This didn't actually find them all, weird.