Add vec/keyset/dict API

hhvm / hack-codegen

Library to programatically generate Hack code and write it to signed files

https://hhvm.github.io/hack-codegen/

MIT License

341 stars 93 forks source link

Add vec/keyset/dict API #51

Closed Neitsch closed 7 years ago

Neitsch commented 7 years ago

Summary: So far hack-codegen supported (Immu)Vector/(Immu)Set/(Immu)Map. Since the new HHVM version introduced vec/keyset/dict, we now add an option to support these collections in the framework.

Test Plan: Added new testcases for each vec/keyset/dict

Notes:

CLA is submitted and should be acknowledged tomorrow
We could probably refactor the collection renderers. It is a lot of duplicate code.

facebook-github-bot commented 7 years ago

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Neitsch commented 7 years ago

This build fails due to HHVM 3.18 not having vec/keyset/dicts. AFAIK HHVM doesn't have anything like conditional compilation, so this will also have to target the 3.x branch

fredemmott commented 7 years ago

Target master; 2.x seems unlikely, I"ll probably just go for 3. If that changes, I can create a 2.x branch from the current master.

fredemmott commented 7 years ago

Merged your other branch in, so no longer testing on 3.18; needs rebase though