foo$bar is not a valid symbol

hhvm / hack-mode

A Emacs major mode for editing Hack code

GNU General Public License v3.0

11 stars 11 forks source link

foo$bar is not a valid symbol #23

Closed Wilfred closed 5 years ago

Wilfred commented 5 years ago

We should only recognise $ at the beginning of a symbol as a symbol constituent.

Wilfred commented 5 years ago

I don't think this is worth fixing. It's unlikely that users will be confused by $foo$bar (I think), and I'm concerned about additional implementation complexity. Fixing this would require another entry in hack--syntax-propertize-function, and since $foo is very common in Hack code, it might hurt performance.