search

hhvm / hacklang.org

The content for hacklang.org
http://hacklang.org
Creative Commons Attribution 4.0 International
21 stars 20 forks source link

Update name in the footer #12

Closed epaes90 closed 6 years ago

epaes90 commented 6 years ago

A suggestion to put a name in the footer instead of "Your name or your company name"

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

epaes90 commented 6 years ago

Hi Guys, It really bugged me to see "Your name or your company name" in the footer. I apologize if it's some internal joke or something like that, but I feel I needed to help fix it.

Thanks

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Orvid commented 6 years ago

cc. @JoelMarcey Looks like we missed a field when doing the Docusaurus migration last week :) (https://github.com/hhvm/hacklang.org/commit/532beeedff5a31eb36231a4b151cb630f1fb2018)

JoelMarcey commented 6 years ago

Hi @epaes90 - thanks for catching this. I merged in https://github.com/hhvm/hacklang.org/pull/11 which was also a fix to this as well.