search

hhvm / hacktest

A unit testing framework for Hack
MIT License
29 stars 12 forks source link

Add allowed fixmes for hhvm 4.62 #101

Closed lexidor closed 4 years ago

lexidor commented 4 years ago 
running HHBBC...
running HHBBC took 0'00" (12575 us) wall time
creating binary HHBC files took 0'00" (13353 us) wall time
running hphp took 0'02" (2651844 us) wall time

std::exception: More than one function with the name
Facebook\\HHAST\\__Private\\hhast_inspect_main_async.
In vendor/hhvm/hhast/bin/hhast-inspect.hack and 
   vendor/bin/hhast-inspect.hack

hphp failed
running hphp took 0'02" (2660893 us) wall time

We can't compile hhbbc because the symlink that composer made creates duplicate definitions. Pretty weird, I can't remember that we've ever had this problem.

fredemmott commented 4 years ago

Yep, regression in 4.62, does not repro on 4.61

fredemmott commented 4 years ago

https://github.com/facebook/hhvm/issues/8719

fredemmott commented 4 years ago

FB T68775322

fredemmott commented 4 years ago

Landed a workaround - @lexidor can you rebase please?