hhvm / hacktest

A unit testing framework for Hack

MIT License

29 stars 13 forks source link

Distinguish errors from failures #20

Closed wlin53 closed 6 years ago

wlin53 commented 6 years ago

14

Nit: remove parens on line 81 in HackTestRunner Test errors are either:

Exceptions that are not instance of PHPUnit_Framework_ExpectationFailedException (e.g. InvariantException)
Errors (e.g. ArgumentCountError)

Misc:

Goal is to support our own exceptions in the expect API...so that they throw something like HackTest_ExpectFailedException
Moved hsl tests to tests/hsl