hhvm / hacktest

A unit testing framework for Hack
MIT License
29 stars 13 forks source link

Move output building to CLI #26

Closed wlin53 closed 6 years ago

wlin53 commented 6 years ago

This way, we can support different CLI modes in the future by only changing the CLI :)

With this change, the ExitCode tests would over-increment by the number of tests they ran (i.e. if testExitSuccess runs test/clean/hsl, it would add an extra ~900 to the number of tests) . This is resolved by returning all of the data including passed tests (hence a nullable Throwable), letting the CLI count the number of tests.