Handle ExpectationFailedException correctly

hhvm / hacktest

A unit testing framework for Hack

MIT License

29 stars 13 forks source link

Handle ExpectationFailedException correctly #63

Closed fredemmott closed 5 years ago

fredemmott commented 5 years ago

migrate from instanceof to is while I'm here
remove support for PHPUnit exceptions
add support for HackTests' own exceptions

This makes the test run clean.

Test plan:

Ran the tests, they pass now. Previously failed as it was indicating ERROR rather than FAILURE, as is expected for unrecognized exceptions being thrown.